Just for some cleanup, get rid of all references to "progressBar1" in the "GenerateWaveformImage" routine and do not pass it to that routine!

In "createAudioBars_Click", update the progressBar1 like this:

                                for (int frame = 0; frame < totalFrames; frame++)
                                {
                                    progressBar1.Invoke((MethodInvoker)delegate { progressBar1.Value = frame; });

                                    int startSample = frame * samplesPerFrame;

Now the progress bar simply runs across as the images are created giving you much better feedback than the flashing progress bar previously gave.

As for the images themselves, I'm not sure what information you're getting exactly into the arrays from the music file without diving deep into researching exactly what is happening. For example, I don't know what it's actually reading here: reader.Read(samples, 0, samples.Length); and then am unsure how it's being used during processing (or even that it's accessing the correct information.)

You might also take a look here - seems like it's doing exactly what you want done without you needing to do all the work:

https://github.com/naudio/NAudio/blob/master/Docs/WaveFormRendering.md

ok i want to create a audio visualiser specially to create a Audio Bars video on black background.

...

Can I ask, why you don't want to use ready-made programs that solve the problem?

For example:

An audio file is input, and a video with a wave is generated at the output.

ok i want to create a audio visualiser specially to create a Audio Bars video on black background.

...

Can I ask, why you don't want to use ready-made programs that solve the problem?

For example:

An audio file is input, and a video with a wave is generated at the output.

what is the name of this program?

 

what is the name of this program?

Astrofox. The program is open source.
(This is not an advertisement.)

bro... you are just GOD to me.... thanksssssssss so much .... 🙏🙏👌👌👌👌👌👌